Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #1633

Merged
merged 7 commits into from
Jan 26, 2023
Merged

Update README.md #1633

merged 7 commits into from
Jan 26, 2023

Conversation

Ishaan2053
Copy link
Contributor

Adding a New Icon?

Nope 🙂

Adding a New Feature or fixing a bug?

Polishing readme.md:

  • Corrected a lot of grammatical errors in the official readme.
  • Added appropriate punctuation to the readme.
    •

    amacado and others added 4 commits March 22, 2022 22:31
    @amacado
    Merge pull request devicons#1084 from devicons/develop
    e7a43b9 
    Fix issue with npm publish script
    @amacado
    bump npm version to v2.15.1
    619c806
    @Thomas-Boi
    Merge pull request devicons#1085 from devicons/draft-release
    1119b9f 
    Build preparation for release v2.15.1
    @Ishaan2053
    Update README.md
    106a4fd 
    Corrected a lot of grammatical errors, added appropriate punctuation to the readme.
    Snailedlt
    Snailedlt approved these changes Jan 18, 2023
    View reviewed changes
    Copy link
    Collaborator

    @Snailedlt Snailedlt left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Neat! Looks good to me ✔️
    Thank you for the contribution! 🚀

    @Snailedlt Snailedlt added the documentation Improvements or additions to documentation label Jan 18, 2023
    @Ishaan2053
    Copy link
    Contributor Author

    Thank you 🫡
    Always happy to contribute🙂

    Panquesito7
    Panquesito7 requested changes Jan 18, 2023
    View reviewed changes
    README.md Outdated Show resolved Hide resolved
    @Panquesito7
    Copy link
    Member

    I guess we should merge this into develop, rather than master.

    Snailedlt
    Snailedlt requested changes Jan 18, 2023
    View reviewed changes
    Copy link
    Collaborator

    @Snailedlt Snailedlt left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Like @Panquesito7 already mentioned, this PR needs to be merged into develop instead of master. Please rebase on develop and change the base branch :)

    @Ishaan2053 @Panquesito7
    Update README.md
    357c990 
    Co-authored-by: David Leal <halfpacho@gmail.com>
    @Ishaan2053 Ishaan2053 changed the base branch from master to develop January 19, 2023 06:07
    @Ishaan2053
    Copy link
    Contributor Author

    I've changed the base branch from master to develop. I hope we're good to go now.

    Panquesito7
    Panquesito7 previously approved these changes Jan 19, 2023
    View reviewed changes
    Copy link
    Member

    @Panquesito7 Panquesito7 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Awesome. Thanks! 🚀

    Snailedlt
    Snailedlt reviewed Jan 19, 2023
    View reviewed changes
    README.md Outdated Show resolved Hide resolved
    @Ishaan2053 @Snailedlt
    Update README.md
    33b1bd9 
    Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
    Panquesito7
    Panquesito7 approved these changes Jan 26, 2023
    View reviewed changes
    Copy link
    Member

    @Panquesito7 Panquesito7 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Overall, looking good. Thanks! 🚀

    README.md
    We have a Discord community for Devicons. You can easily request icons, discuss, and have a good time talking with the community members! Join today: https://discord.gg/hScy8KWACQ.
    <b>Note that the Discord server is unofficial, and Devicons is still being maintained via GitHub.</b>
    We have a Discord community for Devicons. You can easily request icons, discuss, and have a good time talking with the community members! Join today: https://discord.gg/hScy8KWACQ.</p>
    <p><b>Note that the Discord server is unofficial, and Devicons is still being maintained via GitHub.</b>
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Relevant, but for another discussion/issue: is the Discord server still unofficial? I think we should state it as official now.

    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Whoops, didn't see this comment before merging, but yes... I agree. The Discord server should be considered official

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    #1641 PR fixes this🙂, mentioning the server as official.

    @Snailedlt Snailedlt merged commit 6c8db83 into devicons:develop Jan 26, 2023
    @Ishaan2053 Ishaan2053 mentioned this pull request Jan 26, 2023
    Merged
    @Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Snailedlt Snailedlt Snailedlt approved these changes

    @Panquesito7 Panquesito7 Panquesito7 approved these changes

    Assignees
    No one assigned
    Labels
    documentation Improvements or additions to documentation
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @Ishaan2053 @Panquesito7 @Snailedlt @amacado @Thomas-Boi