Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: ecto (original, original-wordmark, plain-wordmark) #1716

Merged
merged 4 commits into from
Apr 9, 2023

Conversation

ruubytes
Copy link
Contributor

@ruubytes ruubytes commented Mar 20, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1713

Link to prove your SVG is correct and up-to-date.

https://github.com/elixir-ecto/ecto

Additional information

The difference between original and plain is that the plain version has no fill attribute.

@lunatic-fox
Copy link
Contributor

Hello there!
Thank you for this contribution!

This icon seems to have an original-wordmark version. You can also make a plain-wordmark version from it.

SVG icon

devicon.json Outdated Show resolved Hide resolved
@Snailedlt Snailedlt self-requested a review March 21, 2023 06:45
@ruubytes ruubytes requested review from lunatic-fox and removed request for Snailedlt March 21, 2023 15:35
@Snailedlt Snailedlt added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Mar 21, 2023
@lunatic-fox lunatic-fox added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Mar 23, 2023
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! ✔
Thank you for this contribution! 🚀

@lunatic-fox lunatic-fox changed the title new icon: ecto (original, plain) new icon: ecto (original, original-wordmark, plain-wordmark) Mar 23, 2023
@ConX ConX self-requested a review March 28, 2023 04:43
Copy link
Contributor

@ConX ConX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruubytes Great work! Thank you for contributing!

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@Panquesito7 Panquesito7 merged commit bd2b9a6 into devicons:develop Apr 9, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants