-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: grpc (original, plain) #1751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions based on: https://grpc.io/img/logos/grpc-logo.svg
original |
plain |
---|---|
Changes:
original
gradient was preservedplain
based on contrast
@lunatic-fox format suggestions Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
@lunatic-fox format suggestions Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
I updated both based on @lunatic-fox's suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Only got an alt name suggestion, otherwise it's excellent
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 🚀
Thank you for this contribution and @Panquesito7 for the screenshots! ✔
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #467
Link to prove your SVG is correct and up-to-date.
https://grpc.io/img/logos/grpc-logo.png