-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: ngrx (original, plain) #1753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Just a few small things to fix before it can be merged
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@Panquesito7 Any idea why the checks are failing? |
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Add newline at the end of file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! ✔
Thank you for this contribution! 🚀
Not sure, seems to be a CodeQL workflow issue, which should be reported separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you for contributing! 🚀
And thanks, @lunatic-fox, for the screenshots. 🙂
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #1725
Link to prove your SVG is correct and up-to-date.
https://github.com/ngrx/platform/blob/0a13c4d89876f1ed399d2ec3cc46bda933a539b8/projects/ngrx.io/src/assets/images/badge.svg