Add optimize_icons workflow triggered on push #1764
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double-check these details before you open a PR
Features
This PR closes #1715
Notes
This PR replaces the now closed #1718.
In the previous version, we were trying to make it run on the PR itself, but that doesn't seem to be possible, given the following:
ericcornelissen/svgo-action@v3
action does not support aworkflow_run
triggerThis version simply runs the optimizer after the PR merge (on the corresponding push). I have tested this with a second fork of the repository, and it seems to work as expected. According to the documentation) when SVGO is invoked on
push
:Doing this on the push has the disadvantage of not allowing us to review the optimized versions, but it will ensure all icons in
develop
are optimized.