Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: sentry (original, original-wordmark) #1877

Merged
merged 4 commits into from
Oct 24, 2023
Merged

new icon: sentry (original, original-wordmark) #1877

merged 4 commits into from
Oct 24, 2023

Conversation

weh
Copy link
Contributor

@weh weh commented Oct 3, 2023 •
edited
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1286
closes #1286

Link to prove your SVG is correct and up-to-date.

https://sentry.io/branding/

@weh weh force-pushed the features/1433-add-sentry-icon branch from e976842 to 8547b3b Compare October 3, 2023 11:01
@weh weh force-pushed the features/1433-add-sentry-icon branch from 8547b3b to 6349fe0 Compare October 3, 2023 11:02
Snailedlt
Snailedlt requested changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!
Could you remove the padding around the icons though?

@weh weh added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 23, 2023
@weh
Copy link
Contributor Author

weh commented Oct 23, 2023

padding is removed

@weh weh requested review from Snailedlt, a team, ConX, canaleal and lunatic-fox and removed request for a team October 24, 2023 09:31
Snailedlt
Snailedlt approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@Snailedlt Snailedlt merged commit d2e6d7b into devicons:develop Oct 24, 2023
5 checks passed
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 5, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

@ConX ConX Awaiting requested review from ConX

@canaleal canaleal Awaiting requested review from canaleal

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weh @Snailedlt