Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new scrollbar #1918

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

new scrollbar #1918

wants to merge 3 commits into from

Conversation

DhruvDutta
Copy link

@DhruvDutta DhruvDutta commented Oct 21, 2023 •
edited by Snailedlt
Loading

fixes #1866

lunatic-fox and others added 2 commits September 1, 2023 15:46
@lunatic-fox
Fix build icons workflow (devicons#1840)
55609aa 
* Fix build icons workflow

* Moving Build Icons to Ubuntu machine
@DhruvDutta
new scrollbar
7d2f0e7
@DhruvDutta
Copy link
Author

image

Snailedlt
Snailedlt previously approved these changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@Snailedlt Snailedlt requested a review from a team October 21, 2023 12:42
@DhruvDutta
Copy link
Author

I'm getting "merging is blocked", is there something wrong from my side?

@Gautam25Raj
Copy link
Contributor

I'm getting "merging is blocked", is there something wrong from my side?

Your PR will be merged once it is Reviewed by at least 2 Maintainers. It need 2 Approvals.

@DhruvDutta
Copy link
Author

DhruvDutta commented Oct 21, 2023 •
edited
Loading

I'm getting "merging is blocked", is there something wrong from my side?

Your PR will be merged once it is Reviewed by at least 2 Maintainers. It need 2 Approvals.

I see, I didn't knew that.

@Snailedlt Snailedlt added hacktoberfest-accepted Accepted to be counted towards Hacktoberfest website Use this label for website related enhancements labels Oct 21, 2023
@ConX
Copy link
Contributor

ConX commented Oct 22, 2023

Hi @DhruvDutta, could you update the description of this PR? What is it for, and what does it fix? Is there an associated issue?

@Snailedlt Snailedlt linked an issue Oct 22, 2023 that may be closed by this pull request
[FEATURE REQUEST] <Styled Scroll bar> #1866
Open
1 task
@Snailedlt
Copy link
Collaborator

@ConX I updated it for him :)

ConX
ConX approved these changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@ConX ConX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the two changes by updating the sources on chrome, and it works great. My only suggestion would be to make the scrollbar width a bit larger.

Here it is with 20px instead of 15px:

image

@DhruvDutta @Snailedlt
Update docs/assets/css/style.css
3ac6926 
Scrollbar width increased to 20px.

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@Snailedlt Snailedlt requested review from a team, weh, canaleal, lunatic-fox and ConX and removed request for a team October 22, 2023 15:23
weh
weh reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on Chrome, but i don't see any changes in Firefox (?)

Snailedlt
Snailedlt previously approved these changes Nov 25, 2023
View reviewed changes
@Snailedlt Snailedlt changed the base branch from master to develop November 25, 2023 16:07
@Snailedlt Snailedlt dismissed their stale review November 25, 2023 16:07

The base branch was changed.

Snailedlt
Snailedlt requested changes Nov 25, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoopsie, it seems this PR had master as the base branch. I changed it to develop, however now there are a few changes to files that shouldn't be changed.

.github/workflows/build_icons.yml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all the changes to this file :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DhruvDutta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weh weh weh left review comments

@Snailedlt Snailedlt Snailedlt requested changes

@canaleal canaleal Awaiting requested review from canaleal

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox

@ConX ConX Awaiting requested review from ConX

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest website Use this label for website related enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] <Styled Scroll bar>
6 participants
@DhruvDutta @Gautam25Raj @ConX @Snailedlt @weh @lunatic-fox