Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: neovim (original, original-wordmark, plain , plain-wordmark, line, line-wordmark) #1962

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

Snailedlt
Copy link
Collaborator

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #717

Link to prove your SVG is correct and up-to-date.

http://neovim.io/
https://neovim.io/logos/neovim-logos.zip
Since all of the colors in the main icon are gradients the color in devicon.json is based on the color of the wordmark logo's text on the website (which is what they use for all the links on the website):
image

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 30, 2023
@Snailedlt Snailedlt requested review from a team, ConX, weh, canaleal and lunatic-fox and removed request for a team October 30, 2023 22:36
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great work.

Only thing that needs to be done is reduce SVG code to 1 line and throw in an empty line at end for all SVGs.

Also, the neovim line SVG looks a little thick on left. It looks to be made from the plain icon so technically that's how it should appear, but the thickness is not seen in the line-wordmark svg.

I don't believe it's an issue, but just pointing out just in case.

@Snailedlt
Copy link
Collaborator Author

@canaleal I joined the lines for all icons.

bleh... you're right about the line icons, but I cba to change it. Too much work for too little. Feel free to fix it if you want though, but to me it's good enough to release... then hopefully someone improves upon it later on :)

Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, all is good.

@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 31, 2023
@Snailedlt Snailedlt merged commit 0e6157c into devicons:develop Nov 1, 2023
5 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants