Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: laravel (original, original-wordmark, line, line-wordmark) #1985

Merged
merged 3 commits into from
Nov 11, 2023

Conversation

canaleal
Copy link
Member

@canaleal canaleal commented Nov 7, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR is related to issues in #1977

Link to prove your SVG is correct and up-to-date.

I updated all the SVGs with the new laravel branding. Plain and Plain-wordmark were removed because the original versions were simple enough to be used as plain versions.

The color was updated to #f0513f to match the new laravel svg fill.

@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 7, 2023
@lunatic-fox lunatic-fox changed the title updated icon: laravel (original, original-wordmark, line, line-wordmark) update icon: laravel (original, original-wordmark, line, line-wordmark) Nov 9, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues were found in original and line versions when I tried to build the icons in IcoMoon.
image
image

Working on the fix! 🔧

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything fixed! 🔧
Thank you for this contribution! 🚀
image
image
image
image

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Looks Great! 💯 Thank you for another great PR! 🙇‍♂️

@Snailedlt Snailedlt merged commit 4c40940 into devicons:develop Nov 11, 2023
9 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants