Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: nim (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2020

Merged
merged 3 commits into from
Dec 3, 2023

Conversation

canaleal
Copy link
Member

@canaleal canaleal commented Nov 19, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR is related to #1998

Link to prove your SVG is correct and up-to-date.

Updated the original svgs to the new Nim logos.
Created a new plain and line SVGs as the original SVGs have multiple paths and fills.
Used the color #ffe953 for the font SVGs.

@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 19, 2023
Snailedlt
Snailedlt previously approved these changes Nov 19, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Great that you changed the color and added more versions too!
image
image
image
image
image

@Snailedlt Snailedlt requested review from a team, ConX, weh and lunatic-fox and removed request for a team November 19, 2023 12:52
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Viewbox is sometimes 120x120 instead of 128x128, the rest looks good 👍

icons/nim/nim-line-wordmark.svg Outdated Show resolved Hide resolved
icons/nim/nim-original-wordmark.svg Outdated Show resolved Hide resolved
icons/nim/nim-plain-wordmark.svg Outdated Show resolved Hide resolved
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine! 👍🏼
Thank you for this contribution! 🚀

@Snailedlt Snailedlt merged commit 400ccaf into devicons:develop Dec 3, 2023
5 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants