Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: travis (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2084

Merged
merged 4 commits into from
Dec 17, 2023

Conversation

canaleal
Copy link
Member

@canaleal canaleal commented Dec 1, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR is related to #1998

Link to prove your SVG is correct and up-to-date.

Additional Notes

The main Travis logo mark is the engineer with the red mustache and yellow hard hat with T symbol. It was somewhat difficult finding a way to simplify the SVG for the plain version, but I decided that it might be best to keep the gray borders and simply remove the fills from the SVGs.

The plain.svg looks simple enough to be used as the line.svg, but maybe both should be added?

The gray color #2d3136 was used for the font SVGs.

@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Dec 1, 2023
@lunatic-fox lunatic-fox requested review from a team, ConX, weh, Snailedlt and lunatic-fox and removed request for a team December 5, 2023 03:49
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally something I can complain about, LOL! (jk)
I just suggested some very minor changes

icons/travis/travis-line-wordmark.svg Outdated Show resolved Hide resolved
icons/travis/travis-line.svg Outdated Show resolved Hide resolved
icons/travis/travis-plain.svg Outdated Show resolved Hide resolved
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👍🏼
Thank you for this contribution! 🚀
image
image
image
image

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for another great contribution! 💯 🙇

@Snailedlt Snailedlt merged commit ca5e533 into devicons:develop Dec 17, 2023
8 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants