Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: visualbasic (original, plain, line) #2087

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

Snailedlt
Copy link
Collaborator

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #910

Continuation of this PR made by @Helder-Machava -> #1871

Link to prove your SVG is correct and up-to-date.

Snailedlt and others added 3 commits December 6, 2023 19:42
Co-authored-by: lunatic-fox <76992016+lunatic-fox@users.noreply.github.com>
Co-authored-by: Helder-Machava <81919768+Helder-Machava@users.noreply.github.com>
@Snailedlt Snailedlt requested review from a team, ConX, weh, canaleal and lunatic-fox and removed request for a team December 6, 2023 18:59
@Snailedlt
Copy link
Collaborator Author

Previews:
image
image
image

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Dec 6, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be ok! 👍🏼
Thank you for this contribution! 🚀

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Snailedlt Snailedlt merged commit 036bd85 into devicons:develop Dec 14, 2023
5 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants