Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: microsoftsqlserver (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2094

Merged
merged 6 commits into from
Jan 8, 2024

Conversation

Snailedlt
Copy link
Collaborator

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

Fixes the issue with this icon in the build: #1998 (comment)

Link to prove your SVG is correct and up-to-date.

Like with all of microsoft's brands it's notoriously difficult to find official logos. I was only able to find the logo on 3rd party sites... and I used this one as the base for all the versions: https://www.svgrepo.com/svg/303229/microsoft-sql-server-logo

Other useful info

I got the color by blending the two red colors (#EE352C and #A91D22) used in the gradient using this tool, which gave me this color: #ee352c

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Dec 17, 2023
@Snailedlt Snailedlt requested review from a team, ConX, weh, canaleal and lunatic-fox and removed request for a team December 17, 2023 13:46
@Snailedlt Snailedlt changed the title Update icon microsoftsqlserver (original, original-wordmark, plain, plain-wordmark) update icon: microsoftsqlserver (original, original-wordmark, plain, plain-wordmark) Dec 17, 2023
@Snailedlt Snailedlt closed this Dec 17, 2023
@Snailedlt Snailedlt reopened this Dec 17, 2023
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all is good, but I don't think plain-wordmark should be used as an alias for the line-wordmark as the text is not outlined/ turned into a line version.

image
image

devicon.json Show resolved Hide resolved
@Snailedlt Snailedlt changed the title update icon: microsoftsqlserver (original, original-wordmark, plain, plain-wordmark) update icon: microsoftsqlserver (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) Dec 23, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be good! 👍🏼
Thank you for this contribution! 🚀
image
image
image
image

Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, all is good.

@canaleal canaleal merged commit 1d4adc8 into devicons:develop Jan 8, 2024
5 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants