Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build preparation for release v2.14.0 #840

Merged
merged 5 commits into from
Sep 8, 2021
Merged

Build preparation for release v2.14.0 #840

merged 5 commits into from
Sep 8, 2021

Conversation

Thomas-Boi and others added 2 commits September 6, 2021 19:09
Co-authored-by: Thomas-Boi <Thomas-Boi@users.noreply.github.com>
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we introduce new icons in this release I propose to create a minor release, resulting in v2.14.0. According to our contribution guidelines

The version naming follows the rules of Semantic Versioning. Given a version number MAJOR.MINOR.PATCH, increment the:
MAJOR version when you make incompatible API changes,
MINOR version when you add functionality (like a new icon) in a backwards compatible manner, and
PATCH version when you make backwards compatible bug fixes.

@Thomas-Boi
Copy link
Member Author

That sounds good. I'll change the version then

Panquesito7
Panquesito7 previously approved these changes Sep 7, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the version is changed. Thanks for preparing this small release, @Thomas-Boi. 😄👍

@Thomas-Boi Thomas-Boi changed the title Build preparation for release v2.13.1 Build preparation for release v2.14.0 Sep 8, 2021
@Thomas-Boi Thomas-Boi merged commit 71049a2 into develop Sep 8, 2021
@Thomas-Boi Thomas-Boi deleted the draft-release branch September 9, 2021 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new release Used when new releases are made.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants