-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: opencv (original, original-wordmark, plain, plain-wordmark) #875
Conversation
Edit the title and initial comment and describe your changes. |
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs. This is how Icomoon intepret the uploaded SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons. This is what the font will look like: You can click on the pictures and zoom on them if needed. The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Thank you for your contribution! 😄👍
new icon: opencv (original, original-wordmark, plain, plain-wordmark)
New icon section
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereLink to prove your SVG is correct and up-to-date
https://opencv.org/resources/media-kit/
This PR adds/fixes
Notes
Can you please add the label 'hacktoberfest-accepted' to this PR. I plan to contribute some more icons, to fulfill (at least) the 4 required Pullrequests.
https://hacktoberfest.digitalocean.com/faq
Any pull request with the hacktoberfest-accepted label, submitted to any public GitHub/GitLab repository, with or without the hacktoberfest topic, will be considered valid for Hacktoberfest.