Add Poison.encode_to_iodata(!)/2 back #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having an explicit function plays nicer with dialyzer and makes Poison simpler to use as callbacks. Ideally we would deprecate the :iodata option in encode and titghen its typespecs but I haven't done so in this commit in order to keep backwards compatibility.
adjust examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was updating libraries in one of the elixir applications where phoenix is configured to use Poison as a
:json_library. Unfortunately, current version of Poison is not compatible with Phoenix because phoenix expects json_library to implementencode_to_iodata!/2(for example here)This PR is just a cherri-pick of the commit from #19
Those changes were lost in this PR
Or is this drop of those functions intentional?