Functions on subdomains (WIP) #1380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1380 +/- ##
==========================================
- Coverage 87.00% 86.75% -0.25%
==========================================
Files 188 188
Lines 27354 26257 -1097
Branches 3712 3740 +28
==========================================
- Hits 23799 22779 -1020
+ Misses 3126 3048 -78
- Partials 429 430 +1
Continue to review full report at Codecov.
|
| @@ -349,28 +349,30 @@ def __init__(self): | |||
| raise ValueError("SubDomain requires a `name`") | |||
| self._dimensions = None | |||
|
|
|||
| def __subdomain_finalize__(self, dimensions, shape, **kwargs): | |||
| def __subdomain_finalize__(self, dimensions, shape, distributor=None, **kwargs): | |||
There was a problem hiding this comment.
not sure I like the new sd terminology...
rhodrin
force-pushed
the
fns_on_subdomains
branch
2 times, most recently
from
bd0f90e
to
980e8c4
Compare
…breaks things for now.
rhodrin
force-pushed
the
fns_on_subdomains
branch
from
148577f
to
cb800dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to define
Function's onSubDomain's, e.g.The shape of the
Dataallocated will then begrid.subdomains['middle'].shape(orgrid.subdomains['middle'].shape_localon each rank with MPI).NOTE: Submitting for testing. Lots of changes and refactoring are still required.