Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FSARequestChangeOwner #291

Merged
merged 1 commit into from
Jan 22, 2023
Merged

Add FSARequestChangeOwner #291

merged 1 commit into from
Jan 22, 2023

Conversation

Xpl0itU
Copy link
Contributor

@Xpl0itU Xpl0itU commented Jan 22, 2023

No description provided.

@fincs fincs merged commit e0f8b37 into devkitPro:master Jan 22, 2023
@@ -593,7 +607,8 @@ struct FSARequest {
FSARequestUnmount unmount;
FSARequestUnmountWithProcess unmountWithProcess;
FSARequestWriteFile writeFile;
WUT_UNKNOWN_BYTES(0x51C);
FSARequestChangeOwner changeOwner;
WUT_UNKNOWN_BYTES(0x28C);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is padding for the union and should stay as 0x51C.

Copy link
Member

@DacoTaco DacoTaco Jan 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping it at 0x51C would make this struct bigger, since changeOwner takes 0x290 of the previous 0x51C unknown bytes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a union not a struct.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my mistake, i scrolled up way to high and saw the struct but didn't see the union.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants