Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AVM and TVE headers, functions and enums #345

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Add AVM and TVE headers, functions and enums #345

merged 2 commits into from
Feb 4, 2024

Conversation

Andrew1Hawes
Copy link
Contributor

My first big PR here so I expect you'll have some suggested changes for me but hopefully most of it is OK.

GaryOderNichts
GaryOderNichts reviewed Feb 2, 2024
View reviewed changes
include/avm/config.h Show resolved Hide resolved
include/avm/config.h Show resolved Hide resolved
GaryOderNichts
GaryOderNichts reviewed Feb 3, 2024
View reviewed changes
Copy link
Contributor

@GaryOderNichts GaryOderNichts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase AVM and TVE into two separate commits? Avoids having one big commit for both.
Looks fine to me otherwise. Thanks for looking into this!

include/avm/tv.h Show resolved Hide resolved
@Andrew1Hawes
Copy link
Contributor Author

I will split it into two commits.

@GaryOderNichts GaryOderNichts merged commit c1115e5 into devkitPro:master Feb 4, 2024
1 check passed
@GaryOderNichts
Copy link
Contributor

Thanks!

@Andrew1Hawes Andrew1Hawes deleted the avm branch April 21, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaryOderNichts GaryOderNichts GaryOderNichts left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andrew1Hawes @GaryOderNichts