Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whb/gfx: Use 4:3 TV buffers on 4:3 TVs #383

Merged
merged 8 commits into from
Jun 14, 2024

Conversation

jranderia3
Copy link
Contributor

Apologies in advance if this doesn't work. I tried adding 4:3 display support in order to use some programs with my older display.

Copy link
Contributor

@GaryOderNichts GaryOderNichts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind that the WHB lib is somewhat limited in general. I recommend avoiding WhbGfx entirely if you intend to do more advanced things (stencil support, different colorbuffer formats, etc.).

libraries/libwhb/src/gfx.c Outdated Show resolved Hide resolved
Copy link
Contributor

@GaryOderNichts GaryOderNichts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some left over newlines, LGTM otherwise. Were you able to test this on a 4:3 TV?

libraries/libwhb/src/gfx.c Outdated Show resolved Hide resolved
libraries/libwhb/src/gfx.c Outdated Show resolved Hide resolved
libraries/libwhb/src/gfx.c Outdated Show resolved Hide resolved
remove some newlines
@jranderia3
Copy link
Contributor Author

Removed the newlines. I tested this on a 4:3 display over composite with the Wii U system settings set to 4:3 480i by recompiling moonlight-wiiu with this change, and it seems to scale correctly.

@GaryOderNichts GaryOderNichts changed the title Attempt at adding 4:3 display support whb/gfx: Use 4:3 TV buffers on 4:3 TVs Jun 14, 2024
@GaryOderNichts GaryOderNichts merged commit c2682dd into devkitPro:master Jun 14, 2024
1 check passed
@GaryOderNichts
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants