Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically escape and unescape constants with semicolon #320

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

kzu
Copy link
Member

@kzu kzu commented Jun 19, 2024

This is a workaround (fix?) for dotnet/roslyn#51692, basically.

We lose all content after the first semicolon in constant and metadata values (presumably Git too).

Project properties also suffer from this, but merits unifying it with ThisAssembly.Constants to continue to streamline the implementation.

This is a workaround (fix?) for dotnet/roslyn#51692, basically.

We lose all content after the first semicolon in constant and metadata values (presumably Git too).

Project properties also suffer from this, but merits unifying it with ThisAssembly.Constants to continue to streamline the implementation.
@kzu kzu added the bug Something isn't working label Jun 19, 2024
@kzu kzu enabled auto-merge (rebase) June 19, 2024 22:10
@kzu kzu merged commit 04431a4 into main Jun 19, 2024
12 checks passed
@kzu kzu deleted the dev/semicolon branch June 19, 2024 22:11
@devlooped devlooped locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant