Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance for mocking interfaces: Cache GetInterfaceMap #1351

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Improve performance for mocking interfaces: Cache GetInterfaceMap #1351

merged 3 commits into from
Aug 16, 2023

Conversation

rauhs
Copy link
Contributor

@rauhs rauhs commented Jul 10, 2023

Fixes #1350.

@stakx
Copy link
Contributor

stakx commented Jul 20, 2023

Thanks for suggesting a fix. Let's wait with a possible merge until we've actually looked at the problem first (see my first comment over in the issue.)

@kzu
Copy link
Member

kzu commented Aug 4, 2023

Could you please rebase on top of main? There were some fixes there. Thanks!

@rauhs rauhs closed this Aug 5, 2023
@rauhs rauhs reopened this Aug 6, 2023
@rauhs
Copy link
Contributor Author

rauhs commented Aug 6, 2023

Could you please rebase on top of main? There were some fixes there. Thanks!

Sorry for the closing/opening. Had a little struggle with git. We're still using svn at $dayjob.

Should be fine now.

@CLAassistant
Copy link

CLAassistant commented Aug 6, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rauhs rauhs force-pushed the main branch 3 times, most recently from d66836e to eb8ccf9 Compare August 8, 2023 06:11
@rauhs
Copy link
Contributor Author

rauhs commented Aug 8, 2023

Any help (i.e. just merge this PR and fix any style changes afterwards) would be highly appreciated. I spend about 5x the time on fighting git than on finding+fixing the actual issue :)

FWIW (and not going to send a PR for this). The following would be good for the editorconfig:

trim_trailing_whitespace = true
csharp_space_before_new_parentheses = false

@rauhs
Copy link
Contributor Author

rauhs commented Aug 9, 2023 •
edited
Loading

@kzu Would love to get this PR merged. Any blockers I need to resolve?

@rauhs rauhs force-pushed the main branch 4 times, most recently from a7268e8 to 59f2513 Compare August 14, 2023 04:16
@kzu
Copy link
Member

kzu commented Aug 16, 2023

Running the checks now!

stakx
stakx approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@stakx stakx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kzu kzu merged commit 1c27e24 into devlooped:main Aug 16, 2023
@devlooped devlooped locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Berezhnyk Berezhnyk Berezhnyk approved these changes

@stakx stakx stakx approved these changes

Assignees

@kzu kzu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance issue with large interfaces
5 participants
@rauhs @stakx @kzu @CLAassistant @Berezhnyk