Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spurious unmerged change comment from dotnet format #1499

Merged
merged 1 commit into from
Aug 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions src/Moq.Tests/ActionObserverFixture.cs
Original file line number Diff line number Diff line change
Expand Up @@ -249,27 +249,13 @@ public void It_IsAny_short_widened_to_int_parameter()
AssertReconstructable(
x => x.VoidWithInt(It.IsAny<short>()),
x => x.VoidWithInt(It.IsAny<short>()));

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private void AssertReconstructable(string expected, Action<IX> action)
After:
void AssertReconstructable(string expected, Action<IX> action)
*/
}

void AssertReconstructable(string expected, Action<IX> action)
{
Expression actual = ActionObserver.Instance.ReconstructExpression(action);
actual = PrepareForComparison.Instance.Visit(actual);
Assert.Equal(expected, actual.ToStringFixed());

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private void AssertReconstructable(Expression<Action<IX>> expected, Action<IX> action)
After:
void AssertReconstructable(Expression<Action<IX>> expected, Action<IX> action)
*/
}

void AssertReconstructable(Expression<Action<IX>> expected, Action<IX> action)
Expand Down Expand Up @@ -336,13 +322,6 @@ public void Stops_before_non_interceptable_property()
public void Stops_after_non_interceptable_return_type()
{
AssertFailsAfter<IX>("x => x.SealedY...", x => x.SealedY.Method());

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private void AssertFailsAfter<TRoot>(string expectedPartial, Action<TRoot> action)
After:
void AssertFailsAfter<TRoot>(string expectedPartial, Action<TRoot> action)
*/
}

void AssertFailsAfter<TRoot>(string expectedPartial, Action<TRoot> action)
Expand Down Expand Up @@ -394,27 +373,13 @@ public void Indexer_with_default_value_on_lfs_and_matcher_on_rhs_both_having_sam
AssertIncorrectlyReconstructsAs(
"x => x[It.IsAny<int>()] = 0",
x => x[0] = It.IsAny<int>());

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private void AssertIncorrectlyReconstructsAs(string expected, Action<IX> action)
After:
void AssertIncorrectlyReconstructsAs(string expected, Action<IX> action)
*/
}

void AssertIncorrectlyReconstructsAs(string expected, Action<IX> action)
{
Expression actual = ActionObserver.Instance.ReconstructExpression(action);
actual = PrepareForComparison.Instance.Visit(actual);
Assert.Equal(expected, actual.ToStringFixed());

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private void AssertIncorrectlyReconstructsAs(Expression<Action<IX>> expected, Action<IX> action)
After:
void AssertIncorrectlyReconstructsAs(Expression<Action<IX>> expected, Action<IX> action)
*/
}

void AssertIncorrectlyReconstructsAs(Expression<Action<IX>> expected, Action<IX> action)
Expand All @@ -429,13 +394,6 @@ public interface IX
{
int this[int index] { get; set; }
void Method(int arg1, int arg2);

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private sealed class PrepareForComparison : ExpressionVisitor
After:
sealed class PrepareForComparison : ExpressionVisitor
*/
}
}

Expand Down
7 changes: 0 additions & 7 deletions src/Moq.Tests/AfterReturnCallbackDelegateValidationFixture.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,6 @@
namespace Moq.Tests
{
public class AfterReturnCallbackDelegateValidationFixture

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private readonly ISetup<IFoo, bool> setup;
After:
readonly ISetup<IFoo, bool> setup;
*/
{
readonly ISetup<IFoo, bool> setup;

Expand Down
30 changes: 0 additions & 30 deletions src/Moq.Tests/CSharpCompilerExpressionsFixture.cs
Original file line number Diff line number Diff line change
Expand Up @@ -130,54 +130,24 @@ public interface IX
void NullableInt(int? arg);
void Object(object arg);
void Short(long arg);

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private static void AssertConvert(Expression<Action<IX>> expression)
After:
static void AssertConvert(Expression<Action<IX>> expression)
*/
}

static void AssertConvert(Expression<Action<IX>> expression)
{
var visitor = new FilteringVisitor(e => e.NodeType == ExpressionType.Convert);
visitor.Visit(expression.Body);
Assert.True(visitor.Result.Any());

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private static void AssertNoConvert(Expression<Action<IX>> expression)
After:
static void AssertNoConvert(Expression<Action<IX>> expression)
*/
}

static void AssertNoConvert(Expression<Action<IX>> expression)
{
var visitor = new FilteringVisitor(e => e.NodeType == ExpressionType.Convert);
visitor.Visit(expression.Body);
Assert.False(visitor.Result.Any());

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private sealed class FilteringVisitor : ExpressionVisitor
After:
sealed class FilteringVisitor : ExpressionVisitor
*/
}
}

sealed class FilteringVisitor : ExpressionVisitor

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private readonly Func<Expression, bool> predicate;
private readonly List<Expression> result;
After:
readonly Func<Expression, bool> predicate;
readonly List<Expression> result;
*/
{
readonly Func<Expression, bool> predicate;
readonly List<Expression> result;
Expand Down
7 changes: 0 additions & 7 deletions src/Moq.Tests/CallbackDelegateValidationFixture.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,6 @@ namespace Moq.Tests
/// </summary>
/// <seealso cref="ReturnsDelegateValidationFixture"/>
public class CallbackDelegateValidationFixture

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private ISetup<IFoo> setup;
After:
ISetup<IFoo> setup;
*/
{
ISetup<IFoo> setup;

Expand Down
7 changes: 0 additions & 7 deletions src/Moq.Tests/CallbacksFixture.cs
Original file line number Diff line number Diff line change
Expand Up @@ -539,13 +539,6 @@ public class Base
}

public class Derived : Base

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private void TraceMe(Base b)
After:
void TraceMe(Base b)
*/
{
}

Expand Down
14 changes: 0 additions & 14 deletions src/Moq.Tests/CustomDefaultValueProviderFixture.cs
Original file line number Diff line number Diff line change
Expand Up @@ -99,23 +99,9 @@ public interface IFoo
int GetValue();
int[] GetValues();
IFoo Inner { get; }

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private sealed class ConstantDefaultValueProvider : DefaultValueProvider
After:
sealed class ConstantDefaultValueProvider : DefaultValueProvider
*/
}

sealed class ConstantDefaultValueProvider : DefaultValueProvider

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private object value;
After:
object value;
*/
{
object value;

Expand Down
14 changes: 0 additions & 14 deletions src/Moq.Tests/CustomTypeMatchersFixture.cs
Original file line number Diff line number Diff line change
Expand Up @@ -258,13 +258,6 @@ public PickyIntOrString() : base(typeof(int), typeof(string))

[TypeMatcher]
public class Picky : ITypeMatcher

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private readonly Type[] types;
After:
readonly Type[] types;
*/
{
readonly Type[] types;

Expand Down Expand Up @@ -301,13 +294,6 @@ public struct AnyStruct : ITypeMatcher
}

public class ObjectStringOrdinalIgnoreCaseComparer : IEqualityComparer<object>

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private static IEqualityComparer<string> InternalComparer => StringComparer.OrdinalIgnoreCase;
After:
static IEqualityComparer<string> InternalComparer => StringComparer.OrdinalIgnoreCase;
*/
{
static IEqualityComparer<string> InternalComparer => StringComparer.OrdinalIgnoreCase;

Expand Down
27 changes: 0 additions & 27 deletions src/Moq.Tests/DefaultValueProviderFixture.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,31 +12,11 @@ namespace Moq.Tests
/// Tests for the <see cref="DefaultValueProvider"/> abstract base class.
/// </summary>
public class DefaultValueProviderFixture

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private static MethodInfo fooActionMethod = typeof(IFoo).GetMethod(nameof(IFoo.Action));
private static ParameterInfo fooActionMethodParameter = typeof(IFoo).GetMethod(nameof(IFoo.Action)).GetParameters()[0];
private static MethodInfo fooFuncMethod = typeof(IFoo).GetMethod(nameof(IFoo.Func));
After:
static MethodInfo fooActionMethod = typeof(IFoo).GetMethod(nameof(IFoo.Action));
static ParameterInfo fooActionMethodParameter = typeof(IFoo).GetMethod(nameof(IFoo.Action)).GetParameters()[0];
static MethodInfo fooFuncMethod = typeof(IFoo).GetMethod(nameof(IFoo.Func));
*/
{
static MethodInfo fooActionMethod = typeof(IFoo).GetMethod(nameof(IFoo.Action));
static ParameterInfo fooActionMethodParameter = typeof(IFoo).GetMethod(nameof(IFoo.Action)).GetParameters()[0];
static MethodInfo fooFuncMethod = typeof(IFoo).GetMethod(nameof(IFoo.Func));


/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private DefaultValueProvider defaultValueProvider;
private Mock<IFoo> fooMock;
After:
DefaultValueProvider defaultValueProvider;
Mock<IFoo> fooMock;
*/
DefaultValueProvider defaultValueProvider;
Mock<IFoo> fooMock;

Expand Down Expand Up @@ -74,13 +54,6 @@ public interface IFoo
{
void Action(object arg);
object Func();

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private sealed class DefaultValueProviderStub : DefaultValueProvider
After:
sealed class DefaultValueProviderStub : DefaultValueProvider
*/
}

sealed class DefaultValueProviderStub : DefaultValueProvider
Expand Down
14 changes: 0 additions & 14 deletions src/Moq.Tests/Demo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,6 @@
namespace Moq.Tests
{
public class Demo

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private static string TALISKER = "Talisker";
After:
static string TALISKER = "Talisker";
*/
{
static string TALISKER = "Talisker";

Expand Down Expand Up @@ -91,13 +84,6 @@ public OrdersPresenter(IOrdersView view)

public Order SelectedOrder { get; private set; }


/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private void DoOrderSelection(Order selectedOrder)
After:
void DoOrderSelection(Order selectedOrder)
*/
void DoOrderSelection(Order selectedOrder)
{
// Do something when the view selects an order.
Expand Down
7 changes: 0 additions & 7 deletions src/Moq.Tests/EmptyDefaultValueProviderFixture.cs
Original file line number Diff line number Diff line change
Expand Up @@ -187,13 +187,6 @@ public void ProvidesDefaultValueTupleOfReferenceTypeArrayAndTaskOfReferenceType(
Assert.NotNull(barTask);
Assert.True(barTask.IsCompleted);
Assert.Equal(default(IBar), barTask.Result);

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private static object GetDefaultValueForProperty(string propertyName)
After:
static object GetDefaultValueForProperty(string propertyName)
*/
}

static object GetDefaultValueForProperty(string propertyName)
Expand Down
37 changes: 0 additions & 37 deletions src/Moq.Tests/ExpressionExtensionsFixture.cs
Original file line number Diff line number Diff line change
Expand Up @@ -109,62 +109,25 @@ public void ToPropertyInfo_does_not_correct_DeclaringType_for_base_properties()
var actual = expression.ToPropertyInfo();

Assert.Same(expected, actual);

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private LambdaExpression ToExpression<T>(Expression<Func<T>> expression)
After:
LambdaExpression ToExpression<T>(Expression<Func<T>> expression)
*/
}

LambdaExpression ToExpression<T>(Expression<Func<T>> expression)
{
return expression;

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private LambdaExpression ToExpression<T>(Expression<Action<T>> expression)
After:
LambdaExpression ToExpression<T>(Expression<Action<T>> expression)
*/
}

LambdaExpression ToExpression<T>(Expression<Action<T>> expression)
{
return expression;

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private LambdaExpression ToExpression<T, TResult>(Expression<Func<T, TResult>> expression)
After:
LambdaExpression ToExpression<T, TResult>(Expression<Func<T, TResult>> expression)
*/
}

LambdaExpression ToExpression<T, TResult>(Expression<Func<T, TResult>> expression)
{
return expression;

/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private void Do<T>(T value) { }
After:
void Do<T>(T value) { }
*/
}

void Do<T>(T value) { }


/* Unmerged change from project 'Moq.Tests(net6.0)'
Before:
private static void DoStatic(int value) { }
private static void DoStaticGeneric<T>(T value) { }
After:
static void DoStatic(int value) { }
static void DoStaticGeneric<T>(T value) { }
*/
static void DoStatic(int value) { }
static void DoStaticGeneric<T>(T value) { }

Expand Down
Loading
Loading