-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When inferring content, PackInference.PackExclude isn't properly evaluated #128
Labels
bug
Something isn't working
Comments
kzu
added a commit
that referenced
this issue
Jul 19, 2021
We were previously assuming Exclude was a valuated while doing the Include for entire item groups, while this is not the case. We need instead to evaluate using the same MSBuild syntax (we use minimatch for this) so we can properly exclude items. Fixes #128.
kzu
added a commit
that referenced
this issue
Jul 19, 2021
We were previously assuming Exclude was a valuated while doing the Include for entire item groups, while this is not the case. We need instead to evaluate using the same MSBuild syntax (we use minimatch for this) so we can properly exclude items. Fixes #128.
kzu
added a commit
that referenced
this issue
Jul 19, 2021
We were previously assuming Exclude was a valuated while doing the Include for entire item groups, while this is not the case. We need instead to evaluate using the same MSBuild syntax (we use minimatch for this) so we can properly exclude items. Fixes #128.
kzu
added a commit
that referenced
this issue
Jul 19, 2021
We were previously assuming Exclude was a valuated while doing the Include for entire item groups, while this is not the case. We need instead to evaluate using the same MSBuild syntax (we use minimatch for this) so we can properly exclude items. Fixes #128.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We're currently including items for inference with the following (somewhat esoteric) MSBuild:
What this does is evaluate the identity of each
PackInference
so that theInclude
contains, for example,@(Content)
. Since theInclude
attribute does not contain actual item specs, theExclude
isn't actually filtering out anything, causing this basic extensibility point in nugetizer to malfunction.Discussed in #120
Originally posted by quasarea June 29, 2021
Hi,
I have library that depends on Grpc.Core package. This package has a targets file that adds assemblies to output
How can I exclude grpc_csharp_ext.x86.dll from being packaged? I have tried several combinations of
But nothing worked :(
The text was updated successfully, but these errors were encountered: