Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nugetize (non-build) tool for dotnet-tool projects #247

Closed
kzu opened this issue Oct 19, 2022 · 0 comments · Fixed by #248
Closed

Allow nugetize (non-build) tool for dotnet-tool projects #247

kzu opened this issue Oct 19, 2022 · 0 comments · Fixed by #248

Comments

@kzu
Copy link
Member

kzu commented Oct 19, 2022

For dotnet tool projects, the design-time build we perform fails since
the tool attempts to publish its output, which the project references won't
be able to supply and the whole thing fails with missing files.

We should pass IsPublishable=false to fake a sort of "DTB" for tools,
so they don't attempt to publish output.

Workaround for now is to invoke nugetize -p:IsPublishable=false

kzu added a commit that referenced this issue Oct 19, 2022
For dotnet tool projects, the design-time build we performed failed since
the tool attempted to publish its output, which the project references weren't
able to supply and the whole thing failed with missing files.

We now pass IsPublishable=false to fake a sort of "DTB" for tools too,
so they don't attempt to publish output.

Fixes #247
kzu added a commit that referenced this issue Oct 19, 2022
For dotnet tool projects, the design-time build we performed failed since
the tool attempted to publish its output, which the project references weren't
able to supply and the whole thing failed with missing files.

We now pass IsPublishable=false to fake a sort of "DTB" for tools too,
so they don't attempt to publish output.

Fixes #247
@kzu kzu closed this as completed in #248 Oct 19, 2022
kzu added a commit that referenced this issue Oct 19, 2022
For dotnet tool projects, the design-time build we performed failed since
the tool attempted to publish its output, which the project references weren't
able to supply and the whole thing failed with missing files.

We now pass IsPublishable=false to fake a sort of "DTB" for tools too,
so they don't attempt to publish output.

Fixes #247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant