New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NuGetizer is incompatible with SDK Pack DevelopmentDependency property #253

Closed

kzu opened this issue Nov 15, 2022 · 0 comments · Fixed by #254

Labels

bug

Member

kzu commented Nov 15, 2022

Describe the Bug

If you set $(DevelopmentDependency)=true in the csproj, nugetizer does not emit the right developmentDependency metadata.

We instead have our own IsDevelopmentDependency. We should deprecate that in favor of the SDK one.

See https://github.com/NuGet/Home/wiki/DevelopmentDependency-support-for-PackageReference for more information.

The text was updated successfully, but these errors were encountered:

kzu added the bug label

kzu added a commit that referenced this issue


          Make IsDevelopmentDependency legacy

f0e98f7

We should support the OOb SDK Pack property instead.
In this case, it's intuitive enough and will likely get
completion support eventually, as well as docs.

See https://github.com/NuGet/Home/wiki/DevelopmentDependency-support-for-PackageReference

Fixes #253

kzu mentioned this issue

Make IsDevelopmentDependency legacy #254

Merged

kzu closed this as completed in #254

kzu added a commit that referenced this issue


          Make IsDevelopmentDependency legacy

c810939

We should support the OOb SDK Pack property instead.
In this case, it's intuitive enough and will likely get
completion support eventually, as well as docs.

See https://github.com/NuGet/Home/wiki/DevelopmentDependency-support-for-PackageReference

Fixes #253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment