Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically default PackageProjectUrl to RepositoryUrl from source control info #91

Closed
kzu opened this issue May 10, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@kzu
Copy link
Member

kzu commented May 10, 2021

If SourceLink is used, the RepositoryUrl will be initialized from the PrivateRepositoryUrl (as long as PublishRepositoryUrl=true). This URL should also be the default for PackageProjectUrl since it's quite common for OSS projects to not have a separate site.

NOTE: neither value is defaulted to the URL unless PublishRepositoryUrl=true, so it's an explicit opt-in, to avoid leaking internal URLs

@kzu kzu added the enhancement New feature or request label May 10, 2021
kzu added a commit that referenced this issue May 10, 2021
If SourceLink is used, the RepositoryUrl will be initialized from the PrivateRepositoryUrl (as long as PublishRepositoryUrl=true). This URL should also be the default for PackageProjectUrl since it's quite common for OSS projects to not have a separate site.

Fixes #91
kzu added a commit that referenced this issue May 10, 2021
If SourceLink is used, the RepositoryUrl will be initialized from the PrivateRepositoryUrl (as long as PublishRepositoryUrl=true). This URL should also be the default for PackageProjectUrl since it's quite common for OSS projects to not have a separate site.

Fixes #91
@kzu kzu closed this as completed in d942404 May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant