Improve compatibility with SDK Pack for tools #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings nugetizer pretty much to parity with SDK Pack for CLI tools too :).
We leverage the SDK tool packing targets to determine the files to pack, but otherwise preserve nugetizer's inference and packing behavior. Best of both worlds!
The new `InferToolContents` target is the one that transforms the `PackTool` target's `TfmSpecificPackageFile` into our own `None` items for packing. It can also be extended to trim the tool's contents via a custom target that removes items, such as::
```xml
<Target Name="TrimRuntimes" AfterTargets="InferToolContents">
<ItemGroup>
<None Remove="@(None)" Condition="$([MSBuild]::ValueOrDefault('%(None.PackagePath)', '').Contains('/runtimes/'))" />
</ItemGroup>
</Target>
```
(this target would remove all runtimes from the tool package, but otherwise preserve the package contents).
Fixes #134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings nugetizer pretty much to parity with SDK Pack for CLI tools too :).
We leverage the SDK tool packing targets to determine the files to pack, but otherwise preserve nugetizer's inference and packing behavior. Best of both worlds!
The new
InferToolContentstarget is the one that transforms thePackTooltarget'sTfmSpecificPackageFileinto our ownNoneitems for packing. It can also be extended to trim the tool's contents via a custom target that removes items, such as::(this target would remove all runtimes from the tool package, but otherwise preserve the package contents).
Fixes #134