Minor improvements to dotnet-nugetize #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the project was not packable, we were not rendering anything, which wasn't very useful when tweaking a project that contributes to a parent package. This adds that capability by explicitly re-running the GetPackageContents target with additional indication that we're collecting contents, so that the package path assignment happens forcedly. Note that this does not account for the potential retargeting of contents if the referencing project happens to redefine the TF (i.e. contributing a NS2 library, but referencing project is net472+net5.0, the lib will actually contribute to both TFMs). Also make it possible to select a specific project if the directory contains more than one, by smartly parsing the extra arguments.
This was causing buildTransitive/* to be grouped under build/*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.