Dev > Main #33
Merged
Dev > Main #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The item metadata on a `PackageReference` may be useful to consumers that use `PrivateAssets` to automatically add implicit package references to transitive dependencies (i.e. to include all dependent assemblies as part of a build tasks assembli). The user-defined metadata may later be used to further tweak the inference (i.e. selectively removing some items from the resulting `PackageFile` items). For this scenario, it's useful to preserve the original metadata in the top-most `PackageReference` that triggers an implicit transitive dependency tree to be a candidate for inference. We also remove from the task the conditional checks on the package reference metadata since the targets already performed the same checks. This makes the task more flexible, should a user decide to invoke it explicitly as part of some custom inference they might want to perform (i.e. inferring content based on different metadata than `PrivateAssets=all`).
Add support for a `PackageReference` metadata attribute on `PackageFile` so that content from other packages can be included more easily. Fixes #30.
This file is only used for nugetizer tasks build itself.
Due to the way we were setting up the BuildDependsOn when PackOnBuild == true, we were running Pack after build, regardless of whether the build was single or multi-targeting. This caused the Pack to run once for each TF, causing each build to overwrite the previous package and therefore leaving only the last TFM built as the package contents. This change switches to using Before/After targets and conditions instead with DependsOn for Build/Pack, as well as a mirror property to PackOnBuild, BuildOnPack to avoid building before pack (which the default behavior in SDK pack too). Fixes #32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.