Automatically pack dependencies satellite resources for private packages #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new `PackSatelliteDlls` property that can be set to `false` to avoid packing the satellite resource assemblies when the project is localized. This setting only applies when `PackBuildOutput=true`. When a `PackageReference` has `PrivateAssets=all`, we assume all assets should be packed alongside the primary output (just as you would see them in the build output). Package references that include satellite resources will show up in the output directory, so it makes sense to also pack them in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new
PackSatelliteDllsproperty that can be set tofalseto avoid packing the satellite resource assemblies when the project is localized. This setting only applies whenPackBuildOutput=true.When a
PackageReferencehasPrivateAssets=all, we assume all assets should be packed alongside the primary output (just as you would see them in the build output). Package references that include satellite resources will show up in the output directory, so it makes sense to also pack them in this case.