Make sure we can explicitly pack a privateassets/development dependency #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzu
force-pushed
the
dev/pack-privateasssets
branch
from
51f0e02
to
e72cbc8
Compare
As a package author, you might consume a development dependency for your own authoring, but also might want to take a dependency on it in your package. GitInfo is an example. We want to make sure we honor explicit Pack=true even if a package has PrivateAssets=all (which has different use cases too).
kzu
force-pushed
the
dev/pack-privateasssets
branch
from
e72cbc8
to
ae7fe3d
Compare
kzu
added a commit
to devlooped/GitInfo
that referenced
this pull request
May 5, 2023
A missing feature in NuGetizer (see devlooped/nugetizer#388) caused our dependency on ThisAssembly.Constants to be lost now that it explicitly sets itself as PrivateAssets=all to prevent analyzer propagation to referenced projects. This scenario (a package reference with PrivateAssets=all AND Pack=true) was not supported by NuGetizer. We now do, so this bump is enough to fix the issue. Fixes #281
kzu
added a commit
to devlooped/GitInfo
that referenced
this pull request
May 5, 2023
A missing feature in NuGetizer (see devlooped/nugetizer#388) caused our dependency on ThisAssembly.Constants to be lost now that it explicitly sets itself as PrivateAssets=all to prevent analyzer propagation to referenced projects. This scenario (a package reference with PrivateAssets=all AND Pack=true) was not supported by NuGetizer. We now do, so this bump is enough to fix the issue. Fixes #281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a package author, you might consume a development dependency for your own authoring, but also might want to take a dependency on it in your package. GitInfo is an example.
We want to make sure we honor explicit Pack=true even if a package has PrivateAssets=all (which has different use cases too).
Fixes #281