-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev > Main #4
Merged
Dev > Main #4
Commits on Sep 29, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9ae354d - Browse repository at this point
Copy the full SHA 9ae354dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 831873f - Browse repository at this point
Copy the full SHA 831873fView commit details -
Add support for building inline project content
This might make it easier for simple project scenarios, also making it easier to understand what files are used in which tests. Currently, this is a bit indirect via the test class name and the corresponding folder under Scenarios.
Configuration menu - View commit details
-
Copy full SHA for 1cb6363 - Browse repository at this point
Copy the full SHA 1cb6363View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9eafc0 - Browse repository at this point
Copy the full SHA f9eafc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56de45e - Browse repository at this point
Copy the full SHA 56de45eView commit details -
Sort root items in package first
This is easier to visualize than the current ordering where they end up last.
Configuration menu - View commit details
-
Copy full SHA for c3551f8 - Browse repository at this point
Copy the full SHA c3551f8View commit details -
Default build package types to not include MSBuild deps
Since the PrivateAssets attribute is not a good fit in this scenario (see NuGet/Home#6041), use the common Pack metadata attribute and default it to false for MSBuild dependencies by default for build package kind. Fixes NuGet/Home#6041
Configuration menu - View commit details
-
Copy full SHA for 437392f - Browse repository at this point
Copy the full SHA 437392fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9f32b8 - Browse repository at this point
Copy the full SHA d9f32b8View commit details
Commits on Sep 30, 2020
-
Automatically pack transitive assets when PrivateAssets=all
When using `<PackageReference PrivateAssets=all `, transitive dependencies were not being brough in. This required package authors to reference explicitly each and every package they wanted packaged as private assets. This was particularly annoying for build and analyzer packages, which need to package all their dependencies privately. This commit leverages the SDK-provided `RunResolvePackageDependencies` which returns the transitive closure of all referenced packages as a list of package>parent list. We use that to add the concept of "implicit package references" that basically share the PrivateAssets=all that brought them in. The inference target then just considers both `@(PackageReference)` as well as `@(ImplicitPackageReference)` to determine the primary output dependencies to pack, but otherwise the existing logic remains unchanged. This behavior still honors the `Pack=false` on the PackageReference, but also skips the implificly defined packages like NETStandard.Library and Microsoft.NETCore. Fixes NuGet/Home#5103.
Configuration menu - View commit details
-
Copy full SHA for 12b3cd7 - Browse repository at this point
Copy the full SHA 12b3cd7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.