Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IDE workspace configuration robust #710

Closed
2 tasks done
hohwille opened this issue Oct 24, 2024 · 0 comments · Fixed by #719
Closed
2 tasks done

Make IDE workspace configuration robust #710

hohwille opened this issue Oct 24, 2024 · 0 comments · Fixed by #719
Assignees
Labels
android-studio Android Studio IDE from Jet-Brains configuration should be configurable or configuration change eclipse related to Eclipse IDE enhancement New feature or request intellij IntelliJ IDE from Jet-Brains vscode Microsoft visual studio code workspace

Comments

@hohwille
Copy link
Member

hohwille commented Oct 24, 2024

Issue #640 revealed that an error in workspace configuration can entirely prevent the IDE (IntelliJ, Eclipse, VSCode, etc.) from being started.
While there will still be workarounds to continue working but average users of IDEasy will then be lost and blocked and do not know how to start their IDE.
Hence, we should invest into robustness and improve UX:

  • when a single workspace template file could not be read/parsed (e.g. invalid JSON, XML, ... or invalid option for merge:strategy, etc.), we should log an error with details about the corrupted file but continue with the workspace merging. However, the workspace merging procedure should then still fail.
  • if the workspace merging procedure fails, IDEasy should log an error that the workspace could not be properly merged and either settings repo is wrong or a bug in IDEasy was hit and ask the user if he wants to continue. This should be done via Step action so that the overall status gets transparent. The user may still run in --batch mode in case such error cannot be fixed for some days to avoid being annoyed by the question. However, the question should raise attention that something is wrong.

See also #644

@hohwille hohwille added enhancement New feature or request android-studio Android Studio IDE from Jet-Brains configuration should be configurable or configuration change vscode Microsoft visual studio code eclipse related to Eclipse IDE intellij IntelliJ IDE from Jet-Brains workspace labels Oct 24, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Oct 24, 2024
@hohwille hohwille self-assigned this Oct 24, 2024
hohwille added a commit to hohwille/IDEasy that referenced this issue Oct 24, 2024
@hohwille hohwille moved this from 🆕 New to 🏗 In progress in IDEasy board Oct 24, 2024
hohwille added a commit to hohwille/IDEasy that referenced this issue Oct 24, 2024
hohwille added a commit to hohwille/IDEasy that referenced this issue Oct 28, 2024
@hohwille hohwille added this to the release:2024.10.001 milestone Oct 28, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in IDEasy board Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-studio Android Studio IDE from Jet-Brains configuration should be configurable or configuration change eclipse related to Eclipse IDE enhancement New feature or request intellij IntelliJ IDE from Jet-Brains vscode Microsoft visual studio code workspace
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant