Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#672: Add configuration for asciidoctor to fail builds when error exist #674

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

alfeilex
Copy link
Member

@alfeilex alfeilex commented Oct 1, 2024

Fixes #672

If there are errors in ascidocs, that PR's added configuration prevents builds to be successful.
Inspiring issue: #590

Example output when error occurs:
[ERROR] Failed to execute goal org.asciidoctor:asciidoctor-maven-plugin:1.6.0:process-asciidoc (generate-doc) on project ide-doc: Found 4 issue(s) of severity ERROR or higher during rendering -> [Help 1]

@alfeilex
Copy link
Member Author

alfeilex commented Oct 1, 2024

After #670 is pushed, the build of this PR should be successful.

@alfeilex alfeilex marked this pull request as ready for review October 1, 2024 16:38
@alfeilex alfeilex self-assigned this Oct 1, 2024
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex thanks for your PR. Very nice that you found out how to do this 👍
Now we finally add value to building the documentation in CI build.
Ready for merge.

@jan-vcapgemini jan-vcapgemini merged commit 2b939e7 into devonfw:main Oct 15, 2024
3 checks passed
@alfeilex alfeilex deleted the #672-asciidoctor-config branch October 15, 2024 07:33
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11340850609

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.803%

Totals Coverage Status
Change from base Build 11296076700: 0.0%
Covered Lines: 6259
Relevant Lines: 9027

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Build should fail when errors exists in doc files
4 participants