Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#675: Fix typos in DoD asciidoc #679

Merged
merged 2 commits into from
Oct 10, 2024
Merged

#675: Fix typos in DoD asciidoc #679

merged 2 commits into from
Oct 10, 2024

Conversation

KianRolf
Copy link
Contributor

@KianRolf KianRolf commented Oct 2, 2024 •
edited by jan-vcapgemini
Loading

Fixes: #675

@KianRolf KianRolf force-pushed the fix/675-fix-typos-in-dod branch from 7af9fc5 to c5f1d5d Compare October 2, 2024 14:33
jan-vcapgemini
jan-vcapgemini approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your corrections. Looks good to me.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11145856527

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.509%
Totals Coverage Status
Change from base Build 11141097628: 0.0%
Covered Lines: 6126
Relevant Lines: 8868
💛 - Coveralls

@jan-vcapgemini jan-vcapgemini added this to the release:2024.10.001 milestone Oct 4, 2024
@jan-vcapgemini jan-vcapgemini added the documentation Improvements or additions to documentation label Oct 7, 2024
hohwille
hohwille approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KianRolf thanks for your PR and finding + fixing all these typos. Nice work 👍
After seeing all this typos we might all want to agree writing AsciiDoc only with a professional tool that has a spell-checker integrated (e.g. IntelliJ with AsciiDoc plugin). I feel like a dyslexic after reading all my own typos ;)

@hohwille hohwille merged commit 3e6fc65 into devonfw:main Oct 10, 2024
3 checks passed
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-vcapgemini jan-vcapgemini jan-vcapgemini approved these changes

@hohwille hohwille hohwille approved these changes

Assignees

@hohwille hohwille

@KianRolf KianRolf

Labels
documentation Improvements or additions to documentation reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.10.001
Development

Successfully merging this pull request may close these issues.

Fix typos in DoD asciidoc
4 participants
@KianRolf @coveralls @hohwille @jan-vcapgemini