#704: fix settings-security.xml not found

[KianRolf]

connected to #704: With this the program successfully locates the settings-security file

[coveralls]

Pull Request Test Coverage Report for Build 11554748217

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 18 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.007%) to 66.767%

---

Files with Coverage Reduction	New Missed Lines	%
com/devonfw/tools/ide/url/model/file/json/ToolDependencies.java	1	76.92%
com/devonfw/tools/ide/context/IdeContext.java	6	58.9%
com/devonfw/tools/ide/tool/mvn/Mvn.java	11	72.22%

Totals
Change from base Build 11550347943:	-0.007%
Covered Lines:	6269
Relevant Lines:	9041

---

💛 - Coveralls

[hohwille]

@KianRolf thanks for your PR. You found the settings.security that is not even documented in the maven-encrpytion-doc. Very nice job for finding this hidden feature what is the major job to solve this story. You also added the config to fix the password encryption. 👍

As I commented, we also need to ensure that we also can decrypt the password when it is to be used. Therefore you need to add this magic system property here:

IDEasy/cli/src/main/java/com/devonfw/tools/ide/context/IdeContext.java

Line 441 in 2024c35

return "-s " + settingsPath;

For a better understanding see also here:

IDEasy/cli/src/main/java/com/devonfw/tools/ide/variable/IdeVariables.java

Line 45 in 2024c35

VariableDefinitionString MAVEN_ARGS = new VariableDefinitionString("MAVEN_ARGS", null, c -> c.getMavenArgs(), false, true);

So this way it will be exported as property and work also work if mvn is called directly by the end-user from his shell after initializing with IDEasy so in scenarios such as this:

ide
mvn clean deploy

compared to

ide mvn clean deploy

Since this will only apply once the settings.xml is created, your existing change in Mvn is still needed and therefore fully correct.

To avoid redundancies, you might want to create a method in Mvn creating the -Dsettings.security=... String so it can be re-used from both places. If you want to make this method private what seems to make sense, you could delegate from IdeContext to a new method getMavenArgs() in Mvn that then returns the entire value of MAVEN_ARGS variable and getMavenArgs() in IdeContext is maily just delegating to that method in Mvn. That would be more clean since maven specific logic should be in Mvn rather than IdeContext (see "Separation of Concerns" pattern).

[hohwille]

@KianRolf thanks for your rework. Now looking perfect to me. 👍
Ready for merge.

[hohwille]

issue was not added to CHANGELOG but I will fix that after merge so we can progress with the release.
Please double check DoD on next PR.