1595 extend uprader to upgrade from monolithic structure to template set.xml #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update mgmt_ide-setup.asciidoc fixed devonfw ide link converted 7, 8 to substeps of 6 added git longpaths configuration step * Update mgmt_ide-setup.asciidoc Improved git remote url setup added PDE manual setup steps
* Update mgmt_ide-setup.asciidoc Updated IDE setup steps with new workarounds because of problems with latest devonfw version. * Update mgmt_ide-setup.asciidoc adjusted typography removed redundant description * Update mgmt_ide-setup.asciidoc fixed spelling errors. * Update mgmt_ide-setup.asciidoc fixed spelling issues.
removed unnecessary tilde
…in (devonfw#1572) Bumps [jsoup](https://github.com/jhy/jsoup) from 1.14.2 to 1.15.3. - [Release notes](https://github.com/jhy/jsoup/releases) - [Changelog](https://github.com/jhy/jsoup/blob/master/CHANGES) - [Commits](jhy/jsoup@jsoup-1.14.2...jsoup-1.15.3) --- updated-dependencies: - dependency-name: org.jsoup:jsoup dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Malte Brunnlieb <maybeec@users.noreply.github.com>
…nd context.xml Next step is deleting the writing of the new context.xml and handling the consequences (code & tests)
quantumfate
requested review from
MikeSchumacherCapgemini,
KHucklenbroich,
morsymegahed,
Lur1an,
jan-vcapgemini,
Zylesto,
NelsonNew,
EduardKrieger,
mdukhan,
ZakariaeMkassi,
Ali7223,
AnnaOsipjan and
leonie19s
quantumfate
changed the title
Modified return type of upgrade method
|
The current implementation (on this branch) extends the upgrade function from V2.1 to V3 and directly generates a template-set.xml (V6) and skips the new context.xml generation. In doing so it breaks a lot of core code that expects new context.xml files from the upgrade. I suggest to integrate this upgrader by skipping the V3 upgrade altogether and go directly from V2.1 Monolithic context.xml to template-sets.xml V6. This will require reworking the AbstractConfigurationUpgrader and related classes/methods. Hint:
|
…ader_to_upgrade_from_monolithic_structure_to_template-set.xml
quantumfate
deleted the
1595_extend_uprader_to_upgradeupgrader_to_upgrade_from_monolithic_structure_to_template-set.xml
branch
quantumfate
restored the
1595_extend_uprader_to_upgradeupgrader_to_upgrade_from_monolithic_structure_to_template-set.xml
branch
quantumfate
deleted the
1595_extend_uprader_to_upgradeupgrader_to_upgrade_from_monolithic_structure_to_template-set.xml
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses/Fixes #1595 .
Implements
@devonfw/cobigen