devonfw/ide#826: Available versions #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hohwille
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
@sarahffm Wow! Excellent and well done. Thanks 👍
Looks like you also implemented and tested error handling so nothing gets broken if CURL produces garbage or fails completely e.g. due to network errors.
Also you handled the case that nothing has changed and git has nothing to commit :)
I left some little questions as review comments but IMHO ready to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devonfw/ide#826 List available versions for a tool
Added a GitHub action to get all available versions as well as all required files for each tool except GitHub CLI and IntelliJ.