#238: fixed extension (#239)

#231: #238: fixed download_dir issue
#239: devon4j 3.1.1
#240: workaround for maven archetype-catalog bug

configurator/src/main/java/com/devonfw/tools/ide/migrator/Migrations.java

@@ -142,7 +142,12 @@ public static MigrationImpl devon4j() {
         .replaceCommentNode(
             "<!DOCTYPE mappings PUBLIC \"-//DOZER//DTD MAPPINGS//EN\" \"http://dozer.sourceforge.net/dtd/dozerbeanmapping.dtd\">",
             "<!DOCTYPE mappings PUBLIC \"-//DOZER//DTD MAPPINGS//EN\" \"https://github.com/DozerMapper/DozerMapper.github.io/blob/master/dtd/bean-mapping.dtd\">")
-        .and().next().build();
+        .and() //
+        .next().to(VersionIdentifier.ofDevon4j("3.1.1")) //
+        .pom().replaceProperty("devon4j.version", "3.1.1") //
+        .replaceProperty("jackson.version", "2.9.9.20190727") //
+        .and() //
+        .next().build();
   }
 
 }

scripts/src/main/resources/scripts/functions

@@ -582,6 +582,11 @@ function doMavenArchetype() {
   then
     target_args+=("-Dversion=1.0.0-SNAPSHOT")
   fi
+  if ! doArrayContainsItemWithPrefix "${target_args[@]}" "-DarchetypeVersion="
+  then
+    doMavenGetLatestVersion "https://repo.maven.apache.org/maven2/${ARCHETYPE_GROUP_ID//.//}/${ARCHETYPE_ARTIFACT_ID}"
+    target_args+=("-DarchetypeVersion=${LATEST_VERSION}")
+  fi
   if [ -z "${target_artifact_id}" ]
   then
     for ((i=1; i < ${#}; i++)) {
@@ -762,6 +767,7 @@ function doInstall() {
     fi
     if [ -n "${DEVON_SOFTWARE_REPOSITORY}" ]
     then
+      extension=".tgz"
       download_url="${DEVON_SOFTWARE_REPOSITORY}/${software}/${version}/${filename}.tgz"
       result=1
       repo="${DEVON_SOFTWARE_REPOSITORY/*:\/\//}"
@@ -798,7 +804,7 @@ function doInstall() {
   if [ ! -d "${install_path}" ] || [ "${install_path}" == "${target_path}" ]
   then
     doDownload "${download_url}" "${filename}" "${download_dir}"
-    doExtract "${DEVON_DOWNLOAD_DIR}/${filename}" "${dir}"
+    doExtract "${download_dir}/${filename}" "${dir}"
     doReplaceExtracted "${DEVON_IDE_HOME}/updates/extracted/${dir}" "${install_path}"
     if [ "${install_path}" != "${DEVON_IDE_HOME}" ]
     then