-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align tool names in scripts #1085
Comments
@hohwille https://github.com/devonfw/cobigen/blob/master/documentation/cobigen-core_configuration.asciidoc |
@hohwille after the issue has been implemented, the doGetToolFolderName function is free of the exceptions and generates the name of the software from the transferred software path. Perhaps the function should be renamed to doGetToolName, or replace the calls directly with the contents of the function. |
node is already adapted |
devonfw#1085 Align tool names in scripts
devonfw#1085 Align tool names in scripts
devonfw#1085 Align tool names in scripts
devonfw#1085 Align tool names in scripts
devonfw#1085 Align tool names in scripts
For epic #941 and as special addition for story #1084 we want to use the migration from
mirrors
tourls
also as cleanup:In general we follow the best practice and convention that if we have a tool
«tool»
then we use the same name in the following places:scripts/command/«tool»
software/[extra/|macos/]«tool»
ide-urls/«tool»/«edition»/«version»/
«TOOL»_VERSION
and«TOOL»_EDITION
devon «tool» «args»
you should get the same effect as when runningdevon
followed by«tool» «args»
except that if the tool is not yet installed in the first case it will be downloaded and installed and in the second case it will fail as the tool is not installed.However, there are currently the following excuses/exceptions to that rule:
mvn
vs.maven
- as the command to run is given asmvn
we have to use that instead ofmaven
consistently.node
vs.nodejs
- as the command to run is given asnode
we have to use that instead ofnodejs
consistently.sonar
vs.sonarqube
- here we do not have any matching given command exceptStartSonar.bat
or the like that is not even in thePATH
after set bydevon
command. For simplicity, I would propose to stay with the shorter namesonar
and renamesonarqube
occurances tosonar
.cobigen
vs.cobigen-cli
vs.cli
. The command is actuallycg
andcobigen
. We can discuss with @jan-vcapgemini but IMHOcobigen
is more self explanatory thancg
that could confuse new users that might never get what this is about and therefore miss the according features behind it.The acceptance criteria of this story is that devonfw-ide strictly follows this rules.
Therefore according scripts (see details above) need to be adapted accordingly.
Further we also have to change our
devon.properties
:ide/scripts/src/main/resources/scripts/devon.properties
Line 18 in 117cc46
Please also do a cleanup of internal variables such as
COBIGEN_CLI_HOME
vs.COBIGEN_HOME
, etc.This story does NOT care about backward compatibility as this is addressed by #1087.
Blocked by dependencies:
The text was updated successfully, but these errors were encountered: