Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate plugins from software #1147

Closed
hohwille opened this issue May 8, 2023 · 4 comments · Fixed by #1179 or devonfw/ide-settings#31
Closed

Separate plugins from software #1147

hohwille opened this issue May 8, 2023 · 4 comments · Fixed by #1179 or devonfw/ide-settings#31
Assignees
Labels
commandlet related to commandlets (scripts/command/*) enhancement New feature or request plugins related to plugins (for Eclipse, Intellij, VSCode, etc.)

Comments

@hohwille
Copy link
Member

hohwille commented May 8, 2023

We should move plugins from software to their own top-level plugins folder as they are something different to the rest we put in software.

Current layout:

/ DEVON_IDE_HOME
└──/ software
   ├──/ az
   ├──/ cobigen-cli
   ├──/ dotnet
   ├──/ eclipse
   ├──/ eclipse-plugins
   ├──/ extra
   ├──/ intellij
   ├──/ intellij-plugins
   ├──/ java
   ├──/ maven
   ├──/ vscode
   └──/ vscode-extensions

New layout proposed by this issue:

/ DEVON_IDE_HOME
├──/ plugins
|  ├──/ eclipse
|  ├──/ intellij
|  └──/ vscode
└──/ software
   ├──/ az
   ├──/ cobigen-cli
   ├──/ dotnet
   ├──/ eclipse
   ├──/ extra
   ├──/ intellij
   ├──/ java
   ├──/ maven
   └──/ vscode

This story affects all commandlets that can have plugins:

@hohwille hohwille added enhancement New feature or request commandlet related to commandlets (scripts/command/*) plugins related to plugins (for Eclipse, Intellij, VSCode, etc.) labels May 8, 2023
@maybeec
Copy link
Member

maybeec commented May 8, 2023

I would not agree to that. What is the benefit? You might even run into incompatibility issues if someone does a major upgrade of an ide causing the ide not to start anymore.

@hohwille
Copy link
Member Author

hohwille commented May 8, 2023

I would not agree to that. What is the benefit? You might even run into incompatibility issues if someone does a major upgrade of an ide causing the ide not to start anymore.

Thanks for your feedback, I try to explain more... not part of this story but for the rationale:

In the future we will enable shared repository by default (for the real solution of #1082).
Then software folder will only contain symbolic links to software tool-edition versions from the central shared software repository (except for the extra folder that we could also eliminate entirely or move from software/extra to extra-software).
Each tool can then have "dependencies" (e.g. jenkins version x1 needs java version j1 while eclipse version e1 needs java version j2 while sonarqube version s1 needs java version j3 causing severe conflicts if j1!=j2!=j3.

For compatibility we introduced migration scripts. We are using this feature also to resolve other "incompatibilities" like #1087.

@jan-vcapgemini jan-vcapgemini self-assigned this May 9, 2023
jan-vcapgemini added a commit to jan-vcapgemini/ide that referenced this issue Jun 5, 2023
changed plugins path for vscode from software/vscode-plugins to plugins/vscode
changed plugins path for intellij from software/intellij-plugins to plugins/intellij
jan-vcapgemini added a commit to jan-vcapgemini/ide that referenced this issue Jun 5, 2023
jan-vcapgemini added a commit to jan-vcapgemini/ide that referenced this issue Jun 5, 2023
added new changes to CHANGELOG
mentioned new plugins folder location in vscode and intellij
jan-vcapgemini added a commit to jan-vcapgemini/ide that referenced this issue Jun 5, 2023
jan-vcapgemini added a commit to jan-vcapgemini/ide that referenced this issue Jun 7, 2023
reverted manual rename of issue
jan-vcapgemini added a commit to jan-vcapgemini/ide that referenced this issue Jun 7, 2023
fixed license link
added doctype book to fix error message in IDE (level 0 sections can only be used when doctype is book)
jan-vcapgemini added a commit to jan-vcapgemini/ide that referenced this issue Jun 7, 2023
added migration of ide-plugins folders to migration script (moves plugins from f.e. software/eclipse-plugins to plugins/eclipse)
jan-vcapgemini added a commit to jan-vcapgemini/ide that referenced this issue Jun 12, 2023
jan-vcapgemini added a commit to jan-vcapgemini/ide that referenced this issue Jun 16, 2023
jan-vcapgemini added a commit to jan-vcapgemini/ide that referenced this issue Jun 16, 2023
added check for existing directory
@hohwille hohwille added this to the release:2023.06.001 milestone Jun 16, 2023
hohwille added a commit to alfeilex/ide that referenced this issue Jun 23, 2023
@hohwille
Copy link
Member Author

While we have implemented the story for intellij, eclipse and vscode now that all is released, I have tested android-studio and notice that it does not implement this plugin separation. As android-studio was in the process of being added (#895) while we were working on this story, I did not notice that it has been forgotten though it was explicitly mentioned in the story description...

@hohwille hohwille reopened this Jul 11, 2023
@hohwille
Copy link
Member Author

I better create a new story for that, as this story is already labelled with milestone 2023.07.001 so reopening and adding changes to the next release will fake the release history and cause confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commandlet related to commandlets (scripts/command/*) enhancement New feature or request plugins related to plugins (for Eclipse, Intellij, VSCode, etc.)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants