Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properties not updated after settings cloned or changed #339

Closed
hohwille opened this issue Jan 14, 2020 · 2 comments
Closed

Properties not updated after settings cloned or changed #339

hohwille opened this issue Jan 14, 2020 · 2 comments
Labels
bug Something isn't working scripts related to shell scripts (bash and CMD) setup related to the setup process of devonfw-ide (setup[.bat] and devon ... setup) software software-package with 3rd party products
Milestone
release:3.2.4

Comments

@hohwille
Copy link
Member

The feature DEVON_IDE_CUSTOM_TOOLS is documented here:
https://github.com/devonfw/ide/blob/master/documentation/software.asciidoc#custom

However, it does not work on the initial setup. When running the setup once again, it works as expected.

Expected behaviour: feature should already work on initial setup.
@hohwille hohwille added bug Something isn't working scripts related to shell scripts (bash and CMD) software software-package with 3rd party products setup related to the setup process of devonfw-ide (setup[.bat] and devon ... setup) labels Jan 14, 2020
@hohwille hohwille added this to the release:3.3.0 milestone Jan 14, 2020
@hohwille
Copy link
Member Author

Problem seems to be that devon ide setup is invoked from setup and clones the settings git after the variables have already been setup. Therefore variables from settings/devon.properties are not loading.

That means this is a fundamental bug that prevents proper configuration from settings for initial setup so all projects will get default tool versions in initial setup.

@hohwille hohwille mentioned this issue Jan 14, 2020
Merged
hohwille added a commit that referenced this issue Jan 14, 2020
@hohwille
#339: reload config after settings have changed (#341)
d0bbabb
@hohwille
Copy link
Member Author

Fixed with PR #339.

@hohwille hohwille changed the title DEVON_IDE_CUSTOM_TOOLS not working on initial setup Properties not updated after settings cloned or changed Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working scripts related to shell scripts (bash and CMD) setup related to the setup process of devonfw-ide (setup[.bat] and devon ... setup) software software-package with 3rd party products
Projects
None yet
Milestone
release:3.2.4
Development

No branches or pull requests
1 participant
@hohwille