Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devon eclipse add-plugin parameters swapped #346

Closed
hohwille opened this issue Jan 24, 2020 · 1 comment
Closed

devon eclipse add-plugin parameters swapped #346

hohwille opened this issue Jan 24, 2020 · 1 comment
Labels
bug Something isn't working commandlet related to commandlets (scripts/command/*) eclipse related to Eclipse IDE scripts related to shell scripts (bash and CMD)
Milestone
release:3.3.0

Comments

@hohwille
Copy link
Member

Expected behavior

Documentation:
https://github.com/devonfw/ide/blob/master/documentation/eclipse.asciidoc#eclipse
Both docs and devon eclipse help state the usage is:

add-plugin «id» [«url»]

Actual behavior

However, the actual implementation expects the URL first if two args are given:

ide/scripts/src/main/resources/scripts/command/eclipse

Line 144 in b5a21c5

doInstallEclipsePlugin "${1}" "${2}"

ide/scripts/src/main/resources/scripts/command/eclipse

Line 6 in b5a21c5

# $1: plugin URL (update site)

Steps to reproduce (bug) / Use Case of feature request (enhancement)

devon eclipse add-plugin "com.genuitec.eclipse.theming.feature.feature.group" "https://www.genuitec.com/updates/devstyle/ci/"

Comments/Hints:

Workaround:

devon eclipse add-plugin "https://www.genuitec.com/updates/devstyle/ci/" "com.genuitec.eclipse.theming.feature.feature.group"

Affected version:

3.2.4
@hohwille hohwille added bug Something isn't working scripts related to shell scripts (bash and CMD) eclipse related to Eclipse IDE commandlet related to commandlets (scripts/command/*) labels Jan 24, 2020
@hohwille hohwille mentioned this issue Jan 24, 2020
Merged
hohwille added a commit that referenced this issue Jan 24, 2020
@hohwille
#346: fixed eclipse add-plugin (#348)
6ba0496
@hohwille
Copy link
Member Author

Fixed with PR #348

@hohwille hohwille added this to the release:3.3.0 milestone Jan 27, 2020
@hohwille hohwille changed the title devon eclipse update-plugin parameters swapped devon eclipse add-plugin parameters swapped Mar 17, 2020
@markusschuh markusschuh mentioned this issue Mar 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working commandlet related to commandlets (scripts/command/*) eclipse related to Eclipse IDE scripts related to shell scripts (bash and CMD)
Projects
None yet
Milestone
release:3.3.0
Development

No branches or pull requests
1 participant
@hohwille