Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange errors on windows if devon.properties contains mixed line endings #424

Closed
hohwille opened this issue Jun 5, 2020 · 0 comments · Fixed by #425
Closed

Strange errors on windows if devon.properties contains mixed line endings #424

hohwille opened this issue Jun 5, 2020 · 0 comments · Fixed by #425
Labels
bug Something isn't working

Comments

@hohwille
Copy link
Member

hohwille commented Jun 5, 2020

OS specific line endings are a big pain. We tried to workaround issues we get when devon.properties have windows line-endings (CRLF).
Now if devon.properties for whatever reason have mixed line endings the property lines having CRLF at the end are causing wired errors on the console like (or even more strange garbage):

': not a valid identifier

Also this error happend:

bash: unset: `': not a valid identifier

We once had a pipe with tr -d '\r' included when reading the devon.properties but this was causing a strange bug:

So we could follow the approach of #394 with this commit:
9694feb

And not only append a trailing newline but also remove CR from any devon.properties automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant