settings still not updated: JsonMerger not writing even if target file not exists #461
Labels
bug
Something isn't working
configurator
related to our configurator tool that manages IDE settings for Eclipse, Intellij, vscode, etc.
Milestone
Related to #432 settings are still not updated/created in some cases:
We discovered a bug here:
ide/configurator/src/main/java/com/devonfw/tools/ide/configurator/merge/JsonMerger.java
Line 61 in e451a41
So we want to avoid overriding files if there are no changes. However, currently this also applies when there was no
setup
file and the target file also does not exist and no variable has been resolved. Thisif
statement also needs to consider if the target file does not exist and in that case always callsave
to save the file.Therefore this bug is not
VS Code
specific but applies for all IDEs if JSON configuration files are used. As this is rarely the case for Eclipse this feature seems to be not properly tested and therefore it only was found now withVS Code
.We should first create a unit-test (failing) and then fixing it by adding the actual bug-fix (red/green pattern) to avoid future issues with things like this.
The text was updated successfully, but these errors were encountered: