Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings still not updated: JsonMerger not writing even if target file not exists #461

Closed
hohwille opened this issue Sep 14, 2020 · 0 comments · Fixed by #462
Closed

settings still not updated: JsonMerger not writing even if target file not exists #461

hohwille opened this issue Sep 14, 2020 · 0 comments · Fixed by #462
Labels
bug Something isn't working configurator related to our configurator tool that manages IDE settings for Eclipse, Intellij, vscode, etc.

Comments

@hohwille
Copy link
Member

Related to #432 settings are still not updated/created in some cases:

We discovered a bug here:

So we want to avoid overriding files if there are no changes. However, currently this also applies when there was no setup file and the target file also does not exist and no variable has been resolved. This if statement also needs to consider if the target file does not exist and in that case always call save to save the file.

Therefore this bug is not VS Code specific but applies for all IDEs if JSON configuration files are used. As this is rarely the case for Eclipse this feature seems to be not properly tested and therefore it only was found now with VS Code.
We should first create a unit-test (failing) and then fixing it by adding the actual bug-fix (red/green pattern) to avoid future issues with things like this.

@hohwille hohwille added bug Something isn't working configurator related to our configurator tool that manages IDE settings for Eclipse, Intellij, vscode, etc. labels Sep 14, 2020
@hohwille hohwille added this to the release:2020.08.002 milestone Sep 14, 2020
@hohwille hohwille linked a pull request Sep 14, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working configurator related to our configurator tool that manages IDE settings for Eclipse, Intellij, vscode, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant