Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntelliJ edition support not working properly #475

Closed
hohwille opened this issue Oct 1, 2020 · 0 comments · Fixed by #476
Closed

IntelliJ edition support not working properly #475

hohwille opened this issue Oct 1, 2020 · 0 comments · Fixed by #476
Labels
bug Something isn't working

Comments

@hohwille
Copy link
Member

hohwille commented Oct 1, 2020

With issue #452 and PR #460 we introduced general support for other IntelliJ editions like Ultimate.
However, the current approach does not work properly:
In devonfw-ide we have created advanced functions for download and installation of software. These rely on a specific tool and version that is downloaded for a given URL. For intellij we provide the same tool ID and version but with different URLs for community edition and ultimate edition. This is leading to various bugs:

Starting installation of intellij to /Users/hohwille/projects/ide/software/intellij from https://download-cf.jetbrains.com/idea/ideaIU-2019.2.dmg
Artifact already exists at /Users/hohwille/Downloads/intellij-2019.2-mac.dmg
To force update please delete the file and run again.

So the "already existing" dowload here was the community edition that gets the same filename.

Also if a project or user would change INTELLIJ_EDITION_TYPE after IntelliJ has already been setup, then devonfw-ide could not notice that anything needs to be updated or changed.

Further, there are advanced features like this https://github.com/devonfw/ide/blob/master/documentation/software.asciidoc#shared that will cause strange effect.

Therefore my suggestion is to add the edition to the logical version of the project that we manage internally in devonfw-ide to make it unique.

@hohwille hohwille added the bug Something isn't working label Oct 1, 2020
@hohwille hohwille added this to the release:2020.08.002 milestone Oct 1, 2020
@hohwille hohwille linked a pull request Oct 1, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant