Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate CobiGen CLI as commandlet #59

Closed
hohwille opened this issue Mar 28, 2019 · 5 comments
Closed

Integrate CobiGen CLI as commandlet #59

hohwille opened this issue Mar 28, 2019 · 5 comments
Assignees
Labels
commandlet related to commandlets (scripts/command/*) enhancement New feature or request scripts related to shell scripts (bash and CMD)
Milestone

Comments

@hohwille
Copy link
Member

It will be a big thing but we definitely need to integrate CobiGen into devon-ide and our new CLI. I leave this issue to the experts from the CobiGen team...

@hohwille hohwille added enhancement New feature or request scripts related to shell scripts (bash and CMD) labels Mar 28, 2019
@hohwille
Copy link
Member Author

hohwille commented Mar 29, 2019

See also #84

@jdiazgon jdiazgon assigned jdiazgon and unassigned jajimene Apr 3, 2019
@hohwille hohwille added the commandlet related to commandlets (scripts/command/*) label Apr 5, 2019
@hohwille hohwille changed the title Integrate CobiGen Integrate CobiGen CLI as commandlet Jun 5, 2019
@hohwille hohwille added this to the release:3.1.0 milestone Aug 2, 2019
hohwille pushed a commit that referenced this issue Jan 14, 2020
@hohwille
Copy link
Member Author

This issue is not complete. Usually PRs should come with code AND documentation.
However, #273 only shipped with cobigen commandlet.
The documentation for this is still missing.
It should be fine to like to the CobiGen CLI documentation but we at least have to create a small AsciiDoc for the cobigen commandlet and link it from the list of commandlets.

@hohwille
Copy link
Member Author

To not block the progress I already merged #273 but also wanted to note that we define a variable for each tool to configure the exact version. This is helpful to allow (large) projects to exactly pre-define the version of the tools used in their devonfw-ide installation. It might be that CobiGen drops support for Java8 and a project still needs to stay on Java8 or the latest CobiGen may be shipped with a bug. Having no way to control this does not meet the goals of devonfw-ide to allow stability and freedom for the projects.
We need an additional PR that will honor an optional COBIGEN_VERSION variable (just analogue to all other commandlets).

@hohwille
Copy link
Member Author

Further, the current approach with doDownload is a hack.
It will not support software updating. You would need to rewrite the entire logic to be able to detect the currently installed version and compare if a newer version is available.
IMHO CobiGen has to provide the CLI in a completely different way as *.tar.gz file with executable Flags and such that it contains what needs to be in the software folder to be fully functional.

cg -h
Error: Unable to access jarfile /Users/hohwille/projects/devon/software/cobigen-cli/cobigen.jar

@hohwille
Copy link
Member Author

Considered done. Created #340 for the remaining issue discussed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commandlet related to commandlets (scripts/command/*) enhancement New feature or request scripts related to shell scripts (bash and CMD)
Projects
None yet
Development

No branches or pull requests

4 participants