Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fork detection buggy #632

Closed
hohwille opened this issue Nov 21, 2021 · 2 comments · Fixed by #769
Closed

fork detection buggy #632

hohwille opened this issue Nov 21, 2021 · 2 comments · Fixed by #769
Assignees
Labels
bug Something isn't working

Comments

@hohwille
Copy link
Member

devon release
origin  https://github.com/m-m-m/code.git (fetch)
origin  https://github.com/m-m-m/code.git (push)
WARNING: You seem to work on a fork. Releases should be done on the original repository!
We strongly recommend to abort and rerun on original repository.

Do you want to continue?
(yes/no):

the repo was no fork as you could easily see. Fork detection is buggy.

@hohwille hohwille added the bug Something isn't working label Nov 21, 2021
@hohwille hohwille self-assigned this May 24, 2022
@hohwille
Copy link
Member Author

I analyzed the problem. The issue happens here:

if git remote -v | grep -q "github.com/${USER}"

Fun fact is that ${USER} is empty and therefore this does not match anymore as expected. This used to work quite some time ago.

hohwille added a commit to hohwille/ide that referenced this issue May 30, 2022
hohwille added a commit to hohwille/ide that referenced this issue May 30, 2022
github user and OS user may differ
@hohwille
Copy link
Member Author

I used $(whoami) instead and it is working again.
Additionally I also checked for upstream in the grep so it gets more reliable as the OS user and the github user may differ.

hohwille added a commit to hohwille/ide that referenced this issue May 30, 2022
optimized to avoid overhead
hohwille added a commit that referenced this issue May 30, 2022
@hohwille hohwille added this to the release:2022.04.002 milestone May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant