Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly test of devonfw-ide installation #691

Closed
3 tasks done
JokeFrels opened this issue Jan 24, 2022 · 7 comments · Fixed by #825
Closed
3 tasks done

Nightly test of devonfw-ide installation #691

JokeFrels opened this issue Jan 24, 2022 · 7 comments · Fixed by #825
Assignees
Labels
ready SCM software-configuration-management (github actions, internal processes, git or github utilization) test related to testing and QA

Comments

@JokeFrels
Copy link

JokeFrels commented Jan 24, 2022

As a devon IDE user I want to install the devon IDE without any difficulties to be able to start right away. Since there can be changes, there should be an automated nightly test with GitHub Actions.

Acceptance criteria:

  • new workflow in github actions for a nightly test (per week)
  • per os (win, mac old, mac M1, linux) use one workflow
  • run build check
@JokeFrels JokeFrels changed the title Nightly test for standard IDE installation Nightly test for devon IDE installation Jan 24, 2022
@hohwille
Copy link
Member

hohwille commented Feb 21, 2022

Please also note that I have already created test-infrastructure:
https://github.com/devonfw/ide/tree/master/scripts/src/test/bash

This is already executed on every build except on windows that does not easily have bash and shellcheck support:
https://github.com/devonfw/ide/blob/master/scripts/pom.xml#L139

IMHO the new tests should be added here and we should find a way to classify tests that should run on every build and others that only run nightly as they are greedy and expensive.

Further also see https://github.com/devonfw/ide-mirrors/issues/3

@maybeec
Copy link
Member

maybeec commented Feb 22, 2022

You can simply declare bash as the shell also on windows for github actions. It will run automatically in git bash.

@hohwille
Copy link
Member

hohwille commented Mar 7, 2022

You can simply declare bash as the shell also on windows for github actions. It will run automatically in git bash.

I am taking about native builds on windows (e.g. mvn install in Windows CMD). As maven-exec-plugin is used, windows says that the bash script is not a native executable and fails. However, I was able to install shellcheck in my gitbash on windows...

@maybeec
Copy link
Member

maybeec commented Mar 7, 2022

Don't get the problem, sry. Could you share a link to a broken build in this regard?

@hohwille
Copy link
Member

hohwille commented Mar 8, 2022

Don't get the problem, sry.

If you run mvn clean install -Pintegration-test on windows, you can reproduce the problem:
https://github.com/devonfw/ide/blob/master/scripts/pom.xml#L139

@alfeilex
Copy link
Member

I get an error in Windows because the shell cannot process the /test-* command correctly. As a result, no test is run.
https://github.com/devonfw/ide/blob/master/scripts/src/test/bash/all-tests#L11

@alfeilex
Copy link
Member

Currently there are no github runner options for m1 devices
actions/runner-images#2187

You would have to host the VM yourself.

@alfeilex alfeilex linked a pull request Jul 13, 2022 that will close this issue
hohwille pushed a commit that referenced this issue Jul 21, 2022
@hohwille hohwille added this to the release:2022.04.004 milestone Jul 21, 2022
@hohwille hohwille changed the title Nightly test for devon IDE installation Nightly test of devonfw-ide installation Jul 30, 2022
@hohwille hohwille added SCM software-configuration-management (github actions, internal processes, git or github utilization) test related to testing and QA labels Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready SCM software-configuration-management (github actions, internal processes, git or github utilization) test related to testing and QA
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants